refactor: add typescript [ECO-1017] #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karantalapalli
requested review from
a team,
Amitkanswal,
surajcontentstack and
abhishek305
surajcontentstack
suggested changes
May 20, 2022
| @@ -75,14 +86,14 @@ export default { | |||
| referenceFieldPath: `navigation_menu.page_reference`, | |||
| jsonRtePath: ['notification_bar.announcement_text'] | |||
| }); | |||
| let responsePages = await Stack.getEntries({ | |||
| let responsePages: [PageResponse] = await Stack.getEntries({ | |||
| contentTypeUid: 'page' | |||
| }); | |||
| let navHeaderList = response[0].navigation_menu; | |||
| if (responsePages.length !== response.length) { | |||
| responsePages.forEach(entry => { | |||
| const hFound = response[0].navigation_menu.find( | |||
src/views/BlogContent.vue
Outdated
| <script lang="ts"> | ||
|
|
||
| interface List { | ||
| author: []; |
| @@ -74,13 +89,13 @@ export default { | |||
| }, | |||
| methods: { | |||
| async getData() { | |||
| const archived = []; | |||
| const recentPost = []; | |||
| const archived = [] as any; | |||
| @@ -97,11 +112,10 @@ export default { | |||
| this.archivedList = archived; | |||
| this.$store.dispatch('setPage', data[0]); | |||
| this.$store.dispatch('setBlogpost', list); | |||
| document.title = this.banner.title; | |||
| const element = document.getElementsByClassName('cslp-tooltip'); | |||
| const element: any = document.getElementsByClassName('cslp-tooltip'); | |||
There was a problem hiding this comment.
check if you can use this$refs to access DOM elements
abhishek305
reviewed
May 20, 2022
There was a problem hiding this comment.
use models instead of interfaces wherever applicable @karantalapalli
Comment on lines
39
to
47
| interface Buckets{ | ||
| title_h3: string; | ||
| description: string; | ||
| } | ||
|
|
||
| interface Data{ | ||
| title_h2: string; | ||
| bucket: Buckets; | ||
| } |
There was a problem hiding this comment.
For individual components have a common file from were you export interface using models
reference: https://dev.to/jwp/typescript-models-and-javascript-objects-31b3
src/components/BlogSection.vue
Outdated
Comment on lines
42
to
56
| interface Article { | ||
| href: string; | ||
| title: string; | ||
| } | ||
|
|
||
| interface Blogs { | ||
| featured_image: Image; | ||
| url: string; | ||
| } | ||
|
|
||
| interface Data { | ||
| title_h2: string; | ||
| view_articles: Article; | ||
| featured_blogs: Blogs; | ||
| } |
There was a problem hiding this comment.
For individual components have a common file from were you export interface using models.
Comment on lines
+50
to
+73
| interface Header { | ||
| local: string; | ||
| logo: string; | ||
| navigation_menu: []; | ||
| notification_bar: string; | ||
| title: string; | ||
| } | ||
|
|
||
| interface Footer { | ||
| local: string; | ||
| logo: string; | ||
| copyright: string; | ||
| navigation: []; | ||
| social: string; | ||
| title: string; | ||
| } | ||
|
|
||
| interface Response { | ||
| page?: string; | ||
| blog_post?: string; | ||
| headers: Header; | ||
| footer: Footer; | ||
| } | ||
|
|
There was a problem hiding this comment.
use models as required
src/components/FooterContent.vue
Outdated
Comment on lines
51
to
59
| interface PageResponse { | ||
| title: string; | ||
| url: string; | ||
| } | ||
|
|
||
| interface Links { | ||
| title: string; | ||
| } | ||
|
|
surajcontentstack
approved these changes
May 23, 2022
abhishek305
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: add typescript [ECO-1017]